From: Florian Müllner <fmuellner@gnome.org>
Date: Sun, 9 Jul 2023 22:00:04 +0000 (+0200)
Subject: dbusServices/extensions: Check earlier for existing dialog
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~337^2~1^2~129
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b4c2901e47f8ce3256faf51381d1884334c3c4ca;p=gnome-shell.git

dbusServices/extensions: Check earlier for existing dialog

There is no point in making a D-Bus call if we are going to bail
out anyway.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2832>
---

diff --git a/js/dbusServices/extensions/extensionsService.js b/js/dbusServices/extensions/extensionsService.js
index ab31a6485..4ef58babf 100644
--- a/js/dbusServices/extensions/extensionsService.js
+++ b/js/dbusServices/extensions/extensionsService.js
@@ -114,11 +114,10 @@ export const ExtensionsService = class extends ServiceImplementation {
         const [uuid, parentWindow, options] = params;
 
         try {
-            const [serialized] = await this._proxy.GetExtensionInfoAsync(uuid);
-
             if (this._prefsDialog)
                 throw new Error('Already showing a prefs dialog');
 
+            const [serialized] = await this._proxy.GetExtensionInfoAsync(uuid);
             const extension = ExtensionUtils.deserializeExtension(serialized);
 
             this._prefsDialog = new ExtensionPrefsDialog(extension);